Loading ...
Sorry, an error occurred while loading the content.

Re: floating bars weirdness with 2.33

Expand Messages
  • schonbach
    Steve, I believe I ve found and fixed the bug. It looks like an incorrect check for an empty overlapcolor was being performed, and thus the overlap bars
    Message 1 of 3 , Jul 10, 2006
    • 0 Attachment
      Steve,

      I believe I've found and fixed the bug. It looks like an incorrect check for an empty
      "overlapcolor" was being performed, and thus the overlap bars were always being drawn.
      My patch is below.

      Regards,
      Mark

      --------------------------------------------------------------
      --- src/proc_bars.c 2006-07-10 19:32:57.000000000 +0000
      +++ src/proc_bars.c 2006-07-10 19:34:01.000000000 +0000
      @@ -604,7 +604,7 @@
      else {
      Ecblock( xleft, Ea( Y, y0 ), xright, Ea( Y, y ), color, 0 );

      - if( overlapcolor != "" && segmentflag ) { /* not documented in 2.33 - color
      change glitches on GD */
      + if( overlapcolor[0] != '\0' && segmentflag ) { /* not documented in 2.33 -
      color change glitches on GD */
      /* See if segments overlap.. if so show the overlap region. Do this before
      outline. added scg 5/11/06 */
      if( y0 < prev_y ) Ecblock( xleft, Ea( Y, y0 ), xright, Ea( Y, prev_y ),
      overlapcolor, do_outline );
      }
      --------------------------------------------------------------


      --- In ploticus@yahoogroups.com, "Stephen C. Grubb" <scg@...> wrote:
      >
      > Mark, thanks for finding this. I was able to reproduce the problem here,
      > and it is definitely a bug in 2.33 ... I'll report back when I've had a
      > chance to look into the problem further. -Steve
    Your message has been successfully submitted and would be delivered to recipients shortly.