Loading ...
Sorry, an error occurred while loading the content.

floating bars weirdness with 2.33

Expand Messages
  • schonbach
    Steve, I just downloaded version 2.33 (I am currently using 2.32). I noticed that with 2.33, floating bars don t render correctly. It looks like each bar
    Message 1 of 3 , Jul 7, 2006
    • 0 Attachment
      Steve,

      I just downloaded version 2.33 (I am currently using 2.32). I noticed that with 2.33,
      floating bars don't render correctly. It looks like each bar also re-renders the outline of
      the bar above it (if the above bar falls within the range of the current bar). It's probably
      easiest to see an example:

      Here is what it looks like with 2.32:
      http://www.markbach.com/stuff/ploticus/bars232.png

      And here is what happens with 2.33:
      http://www.markbach.com/stuff/ploticus/bars233.png

      Here is the script file I used to generate both plots:
      http://www.markbach.com/stuff/ploticus/bars.ploticus

      The command lines I used were:
      /usr/local/bin/pl232 -png -o bars232.png THEVERSION="Ploticus 2.32" bars.ploticus
      /usr/local/bin/pl233 -png -o bars233.png THEVERSION="Ploticus 2.33" bars.ploticus

      I took a quick look at the source for proc_bars.c in 2.32 vs. 2.33, but it looks like a lot has
      changed, so I can't immediately pinpoint a cause. Could you please take a look and let me
      know if I am doing something wrong, or if this is a bug with 2.33? Thanks!

      Regards,
      Mark Schonbach
    • Stephen C. Grubb
      Mark, thanks for finding this. I was able to reproduce the problem here, and it is definitely a bug in 2.33 ... I ll report back when I ve had a chance to
      Message 2 of 3 , Jul 10, 2006
      • 0 Attachment
        Mark, thanks for finding this. I was able to reproduce the problem here,
        and it is definitely a bug in 2.33 ... I'll report back when I've had a
        chance to look into the problem further. -Steve

        On Fri, 7 Jul 2006, schonbach wrote:

        > Steve,
        >
        > I just downloaded version 2.33 (I am currently using 2.32). I noticed that with 2.33,
        > floating bars don't render correctly. It looks like each bar also re-renders the outline of
        > the bar above it (if the above bar falls within the range of the current bar). It's probably
        > easiest to see an example:
        >
        > Here is what it looks like with 2.32:
        > http://www.markbach.com/stuff/ploticus/bars232.png
        >
        > And here is what happens with 2.33:
        > http://www.markbach.com/stuff/ploticus/bars233.png
        >
        > Here is the script file I used to generate both plots:
        > http://www.markbach.com/stuff/ploticus/bars.ploticus
        >
        > The command lines I used were:
        > /usr/local/bin/pl232 -png -o bars232.png THEVERSION="Ploticus 2.32" bars.ploticus
        > /usr/local/bin/pl233 -png -o bars233.png THEVERSION="Ploticus 2.33" bars.ploticus
        >
        > I took a quick look at the source for proc_bars.c in 2.32 vs. 2.33, but it looks like a lot has
        > changed, so I can't immediately pinpoint a cause. Could you please take a look and let me
        > know if I am doing something wrong, or if this is a bug with 2.33? Thanks!
        >
        > Regards,
        > Mark Schonbach
        >
        >
        >
        >
        >
        >


        Stephen C. Grubb scg@... x-6633
        Scientific Software Engineer, The Jackson Laboratory
        600 Main Street Bar Harbor, Maine 04609 USA
      • schonbach
        Steve, I believe I ve found and fixed the bug. It looks like an incorrect check for an empty overlapcolor was being performed, and thus the overlap bars
        Message 3 of 3 , Jul 10, 2006
        • 0 Attachment
          Steve,

          I believe I've found and fixed the bug. It looks like an incorrect check for an empty
          "overlapcolor" was being performed, and thus the overlap bars were always being drawn.
          My patch is below.

          Regards,
          Mark

          --------------------------------------------------------------
          --- src/proc_bars.c 2006-07-10 19:32:57.000000000 +0000
          +++ src/proc_bars.c 2006-07-10 19:34:01.000000000 +0000
          @@ -604,7 +604,7 @@
          else {
          Ecblock( xleft, Ea( Y, y0 ), xright, Ea( Y, y ), color, 0 );

          - if( overlapcolor != "" && segmentflag ) { /* not documented in 2.33 - color
          change glitches on GD */
          + if( overlapcolor[0] != '\0' && segmentflag ) { /* not documented in 2.33 -
          color change glitches on GD */
          /* See if segments overlap.. if so show the overlap region. Do this before
          outline. added scg 5/11/06 */
          if( y0 < prev_y ) Ecblock( xleft, Ea( Y, y0 ), xright, Ea( Y, prev_y ),
          overlapcolor, do_outline );
          }
          --------------------------------------------------------------


          --- In ploticus@yahoogroups.com, "Stephen C. Grubb" <scg@...> wrote:
          >
          > Mark, thanks for finding this. I was able to reproduce the problem here,
          > and it is definitely a bug in 2.33 ... I'll report back when I've had a
          > chance to look into the problem further. -Steve
        Your message has been successfully submitted and would be delivered to recipients shortly.