Loading ...
Sorry, an error occurred while loading the content.

Re: Refactoring of error handling.

Expand Messages
  • motorviper@ymail.com
    Tom, Missed _queuedMessages, will sort that out for next check in. As for the INTERNAL_ERROR stuff thats really a placeholder for where I need to go back and
    Message 1 of 10 , Oct 29, 2009
    • 0 Attachment
      Tom,

      Missed _queuedMessages, will sort that out for next check in.
      As for the INTERNAL_ERROR stuff thats really a placeholder for where I need to go back and think further, I've got some ideas there but not quite ready, they'll be on the back-burner while I finish refactoring the easy stuff.

      Mark.

      --- In pcgen_developers@yahoogroups.com, "thpr" <thpr@...> wrote:
      >
      >
      >
      > --- In pcgen_developers@yahoogroups.com, "motorviper@" <motorviper@> wrote:
      > >
      > > I've changed some of the stuff as you two suggested and checked in the next batch of changes. Most of them are updates to move to the new interface but there are a couple of changes in the persistence.token area.
      >
      > Mark,
      >
      > Looks good for the most part.
      >
      > A few comments:
      >
      > - I still see a leading underscore in _queuedMessages in ComplexParseResult.java
      >
      > - I see ParseResult.INTERNAL_ERROR and I wonder about how this interacts with the overall work you are doing. It looks like much of this is focused on TokenUtilities.getTypeOrPrimitive returning null under an error condition. Is is still useful to have TokenUtilities.getTypeOrPrimitive as an extracted/common method? What about some of the other cases? Curious on your thoughts.
      >
      > TP.
      >
    Your message has been successfully submitted and would be delivered to recipients shortly.