Loading ...
Sorry, an error occurred while loading the content.
 

Re: [pcgen_developers] What's the team position about minor code changes?

Expand Messages
  • James Dempsey
    Hi, Just one caveat with the deprecation messages. If the code with the warnings is in the pcgen.gui package (the old UI code), don t worry about fixing it - I
    Message 1 of 7 , Nov 1, 2012
      Hi,

      Just one caveat with the deprecation messages. If the code with the
      warnings is in the pcgen.gui package (the old UI code), don't worry
      about fixing it - I will be deleting that code very shortly.

      Cheers,
      James.

      On 2/11/2012 7:21 AM javydreamer wrote
      > I've been testing some POM changes (http://jira.pcgen.org/browse/CODE-1822) and I noticed some compilation warnings like:
      >
      > 1) warning: [deprecation] getPcgenOutputSheetDir() in SettingsHandler has been deprecated
      >
      > 2) Missing @Override
      >
      > I've been making this type of changes but I want to know if its worth it?
      >
      > I'm taking care of the obvious deprecations based on the comments in the deprecated methods (i.e. @deprecated Use ConfigurationSettings.getOutputSheetsDir() for item #1) and fixing missing @Overrides in the files I touch.
      >
      > Should I write an issue about this, should I bother?
      >
      >
    Your message has been successfully submitted and would be delivered to recipients shortly.