Re: SERVESAS Corner case issue
- There are 2 ways of dealing with a MULT:YES type scenario in the tokens. We might allow:
SERVESAS:Martial Weapon Proficiency
(effectively the abstract ability without an association)
or (today) we allow:
SERVESAS:Martial Weapon Proficiency (Longsword)
(effectively only allowing a specific implementation of MWP)
Note that the latter can ALWAYS "act" as the former provided you are willing to make the serving more detailed. The former can never act as the latter. So my bias would be to have us implement the latter (require specifics). Certainly that is something you can do in the data today to avoid the error.
Note: I don't believe we want to be in a position of allowing either scenario - I think that gets us back into ambiguity land. We should pick one or the other.
Having said that, it appears that while the token implements #2 (requiring the association), the internal code only enforces #1 (it won't check the association if it exists).
I haven't checked the history of original implementation, to see whether it fully implemented #2, but we should do that, as that is different code than what we have today (note that SERVESAS was originally implemented before much of the non-clone rebuild I've done in 5.17.x)
--- In firstname.lastname@example.org, Andrew <drew0500@...> wrote:
> SEVERE Invalid use of MULT:YES Ability Martial Weapon Proficiency where a target [parens] is required
> SEVERE PLEASE TAKE NOTE: If usage locations are reported, not all usages are necessary illegal (at
> least one is)
> SEVERE Was used in file:/C:/PCGen/data/d20ogl/srd35/basics/rsrd_abilities_class_base.lst in tokens:
> SERESAS is pointing to the base ability as we need this to pass PREFEAT:1,Martial Weapon
> Proficiency, even though MWP is a choice feat.
> How can we make this work so it won't be throwing an error and work as intended?
> Andrew Maitland (LegacyKing)
> Admin Silverback - PCGen Board of Directors
> Data 2nd, Docs Tamarin, OS Lemur
> Unique Title "Quick-Silverback Tracker Monkey"
> Unique Title "The Torturer of PCGen"