Loading ...
Sorry, an error occurred while loading the content.

Question on this [ pcgen-Bugs-1275621 ] BONUS:SPELLKNOWN|CLASS

Expand Messages
  • boomer70
    See my comment below on doing toUpperCase(). Is this something that we support (being that you can use lowercase somewhere even if we specify uppercase in the
    Message 1 of 2 , Sep 2, 2005
    • 0 Attachment
      See my comment below on doing toUpperCase().

      Is this something that we support (being that you can
      use lowercase somewhere even if we specify uppercase
      in the docs?

      I am hesitant to remove this call because this is
      somewhat general parsing code. Should I just hardcode
      a hack that gets around it for this specific case?

      -Aaron

      --- "SourceForge.net" <noreply@...> wrote:

      > To: noreply@...
      > From: "SourceForge.net" <noreply@...>
      > Subject: [ pcgen-Bugs-1275621 ]
      > BONUS:SPELLKNOWN|CLASS
      > Date: Fri, 02 Sep 2005 13:43:06 -0700
      >
      > Bugs item #1275621, was opened at 2005-08-29 07:04
      > Message generated for change (Comment added) made by
      > boomer70
      > You can respond by visiting:
      >
      https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1275621&group_id=25576
      >
      > Please note that this message will contain a full
      > copy of the comment thread,
      > including the initial issue submission, for this
      > request,
      > not just the latest update.
      > Category: None
      > Group: None
      > Status: Open
      > Resolution: None
      > Priority: 8
      > Submitted By: Paul W. King (kingpaul)
      > >Assigned to: Aaron Divinsky (boomer70)
      > Summary: BONUS:SPELLKNOWN|CLASS
      >
      > Initial Comment:
      > Per
      > http://groups.yahoo.com/group/pcgen/message/87130
      >
      > java 1.5r3, WinXp, pcgen 5.9.2:
      > I got the same error with
      > java 1.5, Win2000, pcgen 5.9.1:
      >
      >
      > Is there a problem with
      > BONUS:SPELLKNOWN|CLASS=x;LEVEL=y|z?
      >
      > I've coded some feats which provide bonus spells
      > known
      > to a sorcerer using
      > BONUS:SPELLKNOWN|CLASS=Sorcerer;LEVEL=5|1
      > (at various levels)
      >
      > And when I load PCGen in Debug mode I get:
      >
      > Could not parse token CLASS=SORCERER;LEVEL=5 from
      > bonusInfo CLASS=SORCERER;LEVEL=5 in
      > BonusObj.newBonus.on every one of them.
      >
      > On a similar feat which can choose the class I get:
      > Could not parse token CLASS=%;LEVEL=5 from bonusInfo
      > CLASS=%;LEVEL=5 in BonusObj.newBonus.
      >
      > Is this a preload error I can ignore (sorcerer not
      > known yet) or is
      > BONUS:SPELLKNOWN|CLASS not working?
      >
      > ===
      >
      > Paul W. King
      > TM SB, OGL/PL Chimp, Data Gibbon, BoD
      >
      >
      ----------------------------------------------------------------------
      >
      > >Comment By: Aaron Divinsky (boomer70)
      > Date: 2005-09-02 16:43
      >
      > Message:
      > Logged In: YES
      > user_id=1249558
      >
      > The problem is that the bonus parsing code does a
      > toUpperCase() on the strings it is working with so
      > the system
      > doesn't find a class named "SORCERER".
      >
      >
      >
      ----------------------------------------------------------------------
      >
      > Comment By: Andrew McDougall (tir-gwaith)
      > Date: 2005-08-31 13:48
      >
      > Message:
      > Logged In: YES
      > user_id=208239
      >
      > This is a valid tag. Mostly used inside Choosers in
      > classes,
      > that I recall.
      >
      >
      ----------------------------------------------------------------------
      >
      > Comment By: Eddy Anthony (eddyanthony)
      > Date: 2005-08-31 12:46
      >
      > Message:
      > Logged In: YES
      > user_id=886893
      >
      > The syntax matches what is given in the docs and
      > what is used in the
      > repository. I tested this in 5.9.2 and in 5.8 and it
      > does indeen throw an
      > error and does not grant the bonus.
      >
      > Brocken tag, this is a good candidate for a 5.8 fix
      > as this tag is used 149
      > times in the repository.
      >
      >
      ----------------------------------------------------------------------
      >
      > Comment By: Martijn Verburg (karianna)
      > Date: 2005-08-31 12:03
      >
      > Message:
      > Logged In: YES
      > user_id=252169
      >
      > Eddy, Syntax OK? - K
      >
      >
      ----------------------------------------------------------------------
      >
      > You can respond by visiting:
      >
      https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1275621&group_id=25576
      >




      ____________________________________________________
      Start your day with Yahoo! - make it your home page
      http://www.yahoo.com/r/hs
    • boomer70
      Never mind. I was wrong. Thats not the problem afterall. The problem is actually that no classes are loaded at the time this bonus is parsed. Unfortunately
      Message 2 of 2 , Sep 2, 2005
      • 0 Attachment
        Never mind. I was wrong. Thats not the problem
        afterall. The problem is actually that no classes are
        loaded at the time this bonus is parsed.
        Unfortunately a bigger fix though.

        --- boomer70 <boomer70@...> wrote:

        > See my comment below on doing toUpperCase().
        >
        > Is this something that we support (being that you
        > can
        > use lowercase somewhere even if we specify uppercase
        > in the docs?
        >
        > I am hesitant to remove this call because this is
        > somewhat general parsing code. Should I just
        > hardcode
        > a hack that gets around it for this specific case?
        >
        > -Aaron
        >
        > --- "SourceForge.net" <noreply@...>
        > wrote:
        >
        > > To: noreply@...
        > > From: "SourceForge.net" <noreply@...>
        > > Subject: [ pcgen-Bugs-1275621 ]
        > > BONUS:SPELLKNOWN|CLASS
        > > Date: Fri, 02 Sep 2005 13:43:06 -0700
        > >
        > > Bugs item #1275621, was opened at 2005-08-29 07:04
        > > Message generated for change (Comment added) made
        > by
        > > boomer70
        > > You can respond by visiting:
        > >
        >
        https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1275621&group_id=25576
        > >
        > > Please note that this message will contain a full
        > > copy of the comment thread,
        > > including the initial issue submission, for this
        > > request,
        > > not just the latest update.
        > > Category: None
        > > Group: None
        > > Status: Open
        > > Resolution: None
        > > Priority: 8
        > > Submitted By: Paul W. King (kingpaul)
        > > >Assigned to: Aaron Divinsky (boomer70)
        > > Summary: BONUS:SPELLKNOWN|CLASS
        > >
        > > Initial Comment:
        > > Per
        > > http://groups.yahoo.com/group/pcgen/message/87130
        > >
        > > java 1.5r3, WinXp, pcgen 5.9.2:
        > > I got the same error with
        > > java 1.5, Win2000, pcgen 5.9.1:
        > >
        > >
        > > Is there a problem with
        > > BONUS:SPELLKNOWN|CLASS=x;LEVEL=y|z?
        > >
        > > I've coded some feats which provide bonus spells
        > > known
        > > to a sorcerer using
        > > BONUS:SPELLKNOWN|CLASS=Sorcerer;LEVEL=5|1
        > > (at various levels)
        > >
        > > And when I load PCGen in Debug mode I get:
        > >
        > > Could not parse token CLASS=SORCERER;LEVEL=5 from
        > > bonusInfo CLASS=SORCERER;LEVEL=5 in
        > > BonusObj.newBonus.on every one of them.
        > >
        > > On a similar feat which can choose the class I
        > get:
        > > Could not parse token CLASS=%;LEVEL=5 from
        > bonusInfo
        > > CLASS=%;LEVEL=5 in BonusObj.newBonus.
        > >
        > > Is this a preload error I can ignore (sorcerer not
        > > known yet) or is
        > > BONUS:SPELLKNOWN|CLASS not working?
        > >
        > > ===
        > >
        > > Paul W. King
        > > TM SB, OGL/PL Chimp, Data Gibbon, BoD
        > >
        > >
        >
        ----------------------------------------------------------------------
        > >
        > > >Comment By: Aaron Divinsky (boomer70)
        > > Date: 2005-09-02 16:43
        > >
        > > Message:
        > > Logged In: YES
        > > user_id=1249558
        > >
        > > The problem is that the bonus parsing code does a
        > > toUpperCase() on the strings it is working with so
        > > the system
        > > doesn't find a class named "SORCERER".
        > >
        > >
        > >
        >
        ----------------------------------------------------------------------
        > >
        > > Comment By: Andrew McDougall (tir-gwaith)
        > > Date: 2005-08-31 13:48
        > >
        > > Message:
        > > Logged In: YES
        > > user_id=208239
        > >
        > > This is a valid tag. Mostly used inside Choosers
        > in
        > > classes,
        > > that I recall.
        > >
        > >
        >
        ----------------------------------------------------------------------
        > >
        > > Comment By: Eddy Anthony (eddyanthony)
        > > Date: 2005-08-31 12:46
        > >
        > > Message:
        > > Logged In: YES
        > > user_id=886893
        > >
        > > The syntax matches what is given in the docs and
        > > what is used in the
        > > repository. I tested this in 5.9.2 and in 5.8 and
        > it
        > > does indeen throw an
        > > error and does not grant the bonus.
        > >
        > > Brocken tag, this is a good candidate for a 5.8
        > fix
        > > as this tag is used 149
        > > times in the repository.
        > >
        > >
        >
        ----------------------------------------------------------------------
        > >
        > > Comment By: Martijn Verburg (karianna)
        > > Date: 2005-08-31 12:03
        > >
        > > Message:
        > > Logged In: YES
        > > user_id=252169
        > >
        > > Eddy, Syntax OK? - K
        > >
        > >
        >
        ----------------------------------------------------------------------
        > >
        > > You can respond by visiting:
        > >
        >
        https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1275621&group_id=25576
        > >
        >
        >
        >
        >
        > ____________________________________________________
        > Start your day with Yahoo! - make it your home page
        > http://www.yahoo.com/r/hs
        >
        >


        __________________________________________________
        Do You Yahoo!?
        Tired of spam? Yahoo! Mail has the best spam protection around
        http://mail.yahoo.com
      Your message has been successfully submitted and would be delivered to recipients shortly.