Loading ...
Sorry, an error occurred while loading the content.

[Eddy] Re: Modern OS (PDF) and Armor Class

Expand Messages
  • Chuck Pint
    Looked it over in detail, and committed to CVS (I hope the correct branch). Chuck OS Chimp ... your work. ... would ... Wouldn t they ... There
    Message 1 of 5 , Jun 21, 2005
    • 0 Attachment
      Looked it over in detail, and committed to CVS (I hope the correct
      branch).

      Chuck
      OS Chimp


      --- In pcgen@yahoogroups.com, Eddy Anthony <eddyba@m...> wrote:
      > Franks work looks good to me, I say go for it.
      > --
      > ~ Eddy Anthony (MoSaT)
      > ~ PCGen Content Silverback
      >
      > Chuck Pint scribed:
      >
      > > Actually, since I know next to nothing about the Modern rules and
      > > such, everything you said sounds fine to me. :) Eddy has been doing
      > > more of the support on Modern than I have. Eddy may have a different
      > > take, but it sounds to me like you've done a good job checking
      your work.
      > >
      > > Chuck
      > > OS Chimp
      > >
      > > --- In pcgen@yahoogroups.com, "Frank Kliewe" <fkliewe@t...> wrote:
      > >> Over the weekend I fiddled a bit more with the modern OS (PDF).
      > > Except for the previously stated AC split-up problem, I discovered 2
      > > more "glitches".
      > >>
      > >> - the Skill block wouldn't display negative values for the MISC
      > > Modifier. I fixed that by changing the tag <xsl:if test="misc_mod>0">
      > > to <xsl:if test="misc_mod!=0"> in the skills table
      > >>
      > >> - the Base Attack Bonus would be displayed as ++1 instead of
      > > +1. I fixed that by replacing the Generic Process <xsl:template
      > > name="process.attack.string"> with the one from the fantasy.common.xsl
      > > by the same name. Since the Base Attack Bonus is essentially the same
      > > in Modern and Fantasy I don't think there should be a problem here. (I
      > > got to admit though, that I do not fully understand that template).
      > >>
      > >> I also made a minor change to the Weapon Block. In Modern with
      > > automatic weapons and semi-automatic weapons the Rate of Fire is more
      > > important, therefore I added a section to the special properties
      > > template, that shortens the special properties output of the weapons
      > > block and puts the Rate of Fire in front of that line, but only for
      > > ranged and thrown weapons.
      > >>
      > >> So, Chuck, if you might be interested to check out the final result,
      > > and maybe put it into CVS if it is to your liking and standards, I
      > > could upload the result on experimental. If not feel free to ignore my
      > > babbling. ;)
      > >>
      > >> Cheerio,
      > >>
      > >> Frank Kliewe
      > >> PCGen Data Lemur
      > >>
      > >> ----- Original Message -----
      > >> From: "Chuck Pint" <pcgen@c...>
      > >> To: <pcgen@yahoogroups.com>
      > >> Sent: Friday, June 03, 2005 10:34 PM
      > >> Subject: [pcgen] Re: Modern OS (PDF) and Armor Class
      > >>
      > >>
      > >>> --- In pcgen@yahoogroups.com, "Frank Kliewe" <fkliewe@t...> wrote:
      > >>>> The PDF OS (and the Preview in Browser) do not display the
      > >>> AC-split-up correctly.
      > >>>>
      > >>>> The Equipment Bonus is not printed out and the MISC bonus is
      > >>> displayed as "NaN".
      > >>>>
      > >>>> I think both problems come from missing definitions in Base.xml.
      > >>>>
      > >>>> The Equipment Bonus would need a definition
      > >>> <equipment_bonus>|AC.Equipment|</equipment_bonus>. (I know next to
      > >>> nothing about OS, so I don't have a clue whether this definition
      would
      > >>> have side effects on the other sheets, like fantasy, or spycraft).
      > >>>>
      > >>>> The Misc Bonus in csheet_modern_std.xslt looks like:
      > >>>>
      > >>>> <xsl:value-of select="misc + competence_bonus + defense_bonus +
      > >>> dodge_bonus + enhancement_bonus + insight_bonus + luck_bonus +
      > >>> monk_bonus + sidestep_bonus + tar_bonus + toughness_bonus"/>
      > >>>>
      > >>>> I think the "NaN" comes from some of these XXX_bonus not being
      > >>> defined in Base.xml as well. Are all of these necessary?
      Wouldn't they
      > >>> be included in "misc" anyway? At least the equipment_bonus is, so
      > >>> maybe a simple <xsl:value-of select="misc - equipment_bonus"/>
      > > would do?
      > >>>
      > >>> I don't know much about Modern. But I do know the OS very well.
      There
      > >>> is no problem with putting a statement like:
      > >>> <equipment_bonus>|AC.Equipment|</equipment_bonus>
      > >>> in BASE.XML.
      > >>>
      > >>> As for the Misc Bonus, you're right that just plain looks wrong. The
      > >>> following are not defined in BASE.XML:
      > >>> competence_bonus
      > >>> defense_bonus
      > >>> enhancement_bonus
      > >>> insight_bonus
      > >>> luck_bonus
      > >>> monk_bonus
      > >>> sidestep_bonus
      > >>> tar_bonus
      > >>> toughness_bonus
      > >>> So given that all those are undefined, of course you'll get NaN.
      > >>>
      > >>> On the fanstasy version of this, the misc consists of:
      > >>> misc + class_bonus + dodge_bonus
      > >>>
      > >>> So your mod might just be right.
      > >>>
      > >>> Chuck
      > >>> OS Chimp
    Your message has been successfully submitted and would be delivered to recipients shortly.