Loading ...
Sorry, an error occurred while loading the content.

Re: [nuttx] Notify sockets about a lost connection

Expand Messages
  • Max Holtzberg
    ... When I look on the commit I think maybe its better to do: if ((conn- tcpstateflags & UIP_CLOSED) != 0)
    Message 1 of 6 , Sep 6, 2013
    • 0 Attachment
      Am 06.09.2013 17:20, schrieb Gregory Nutt:
      > This change is now available in GIT at commit 70d21b8c25966310cf3fc123092f10f297e8a653
      >

      When I look on the commit I think maybe its better to do:

      if ((conn->tcpstateflags & UIP_CLOSED) != 0)
    • Gregory Nutt
      ... You are right!  Fixed in commit 1e205dcb3cffced05d77eeec92e48deaffb478c7 Greg
      Message 2 of 6 , Sep 6, 2013
      • 0 Attachment
        > > This change is now available in GIT at commit 70d21b8c25966310cf3fc123092f10f297e8a653
        > >
        >
        > When I look on the commit I think maybe its better to do:
        >
        > if ((conn->tcpstateflags & UIP_CLOSED) != 0)

        You are right!  Fixed in commit 1e205dcb3cffced05d77eeec92e48deaffb478c7

        Greg
      • Max Holtzberg
        ... Unfortunately UIP_CLOSED is defined to 0, so this has to be changed back to: if (conn- tcpstateflags == UIP_CLOSED) Max
        Message 3 of 6 , Sep 25, 2013
        • 0 Attachment
          Am 06.09.2013 17:30, schrieb Max Holtzberg:
          > Am 06.09.2013 17:20, schrieb Gregory Nutt:
          >> This change is now available in GIT at commit 70d21b8c25966310cf3fc123092f10f297e8a653
          >>
          >
          > When I look on the commit I think maybe its better to do:
          >
          > if ((conn->tcpstateflags & UIP_CLOSED) != 0)
          >

          Unfortunately UIP_CLOSED is defined to 0, so this has to be changed
          back to:

          if (conn->tcpstateflags == UIP_CLOSED)

          Max
        • Gregory Nutt
          Hi, Max, ... Thanks.  The change is checked in. Greg
          Message 4 of 6 , Sep 25, 2013
          • 0 Attachment
            Hi, Max,


            >>> This change is now available in GIT at commit 70d21b8c25966310cf3fc123092f10f297e8a653
            >>
            >> When I look on the commit I think maybe its better to do:
            >>
            >> if ((conn->tcpstateflags & UIP_CLOSED) != 0)
            >>
            >
            > Unfortunately UIP_CLOSED is defined to 0, so this has to be changed
            > back to:
            >
            > if (conn->tcpstateflags == UIP_CLOSED)

            Thanks.  The change is checked in.

            Greg
          Your message has been successfully submitted and would be delivered to recipients shortly.