Loading ...
Sorry, an error occurred while loading the content.

Re: [linuxham] fldigi --wfall-only

Expand Messages
  • John Phelps
    Hi All, Found a possible bugfix for the waterfall-only mode crashing issue. (files attached) Works well here in testing. Attached is both a patch/fix and
    Message 1 of 14 , Feb 3, 2013
    Hi All,

    Found a possible bugfix for the waterfall-only mode crashing issue. (files attached)
    Works well here in testing.
    Attached is both a patch/fix and screenshot of my debugger window (showing error and justifying why fix was placed here in program-flow)

    My only question is: Do users want or need the Rx stream processed in waterfall-only mode?
    ... guess I am asking for the technical definition of how waterfall-only should waterfall-only mode be, hihi.


    Summary of the fix/patch.
    This disables all processing of Rx text while in --wfall-only mode

    +++ b/src/dialogs/fl_digi.cxx
    @@ -6142,6 +6142,9 @@ static void put_rx_char_flmain(unsigned int data, int style)
     {
      ENSURE_THREAD(FLMAIN_TID);
     
    + // If in Waterfall Only mode: skip all processing of Rx characters
    + if (bWF_only) return;



    ~ John Phelps 
    kl4yfd



  • w1hkj
    ... Thanks John ... I ll import your patch into both 3.21 and 3.22 branches. Waterfall only is supposed to be just that, but the text stream has to be
    Message 2 of 14 , Feb 3, 2013
    • 0 Attachment
      On 02/03/2013 12:55 PM, John Phelps wrote:
      Hi All,

      Found a possible bugfix for the waterfall-only mode crashing issue. (files attached)
      Works well here in testing.
      Attached is both a patch/fix and screenshot of my debugger window (showing error and justifying why fix was placed here in program-flow)

      My only question is: Do users want or need the Rx stream processed in waterfall-only mode?
      ... guess I am asking for the technical definition of how waterfall-only should waterfall-only mode be, hihi.


      Summary of the fix/patch.
      This disables all processing of Rx text while in --wfall-only mode

      +++ b/src/dialogs/fl_digi.cxx
      @@ -6142,6 +6142,9 @@ static void put_rx_char_flmain(unsigned int data, int style)
       {
        ENSURE_THREAD(FLMAIN_TID);
       
      + // If in Waterfall Only mode: skip all processing of Rx characters
      + if (bWF_only) return;



      ~ John Phelps 
      kl4yfd

      Thanks John ... I'll import your patch into both 3.21 and 3.22 branches.

      Waterfall only is supposed to be just that, but the text stream has to be available via the xmlrpc calls.

      Dave
    • w1hkj
      JP almost had it right on the WF-only patch. Please apply this one to 3.21.67 to cure this seg fault. BTW, this is not a fault one would expect to encounter
      Message 3 of 14 , Feb 3, 2013
      • 1 Attachment
      • 1 KB
      JP almost had it right on the WF-only patch. Please apply this one to
      3.21.67 to cure this seg fault.

      BTW, this is not a fault one would expect to encounter unless:

      You started fldigi in full screen mode.
      Enabled the "File | Text capture | Log all RX/TX text" menu item
      Exited fldigi

      Started fldigi with the command line sequence "--wo" or "--waterfall-only"
      Started decoding incoming data

      Most users of the --wo command line switch are in MS world and use
      ancillary programs to display the text, and other aspects of fldigi
      operation. Those programs use fldigi as a modem engine with waterfall
      display. They would rarely if ever have performed the above sequence of
      operations.

      73, Dave, W1HKJ
    Your message has been successfully submitted and would be delivered to recipients shortly.