Loading ...
Sorry, an error occurred while loading the content.
 

[Cheetahtemplate-discuss] Re: WebSafe filter broken in last Cheetah releases?

Expand Messages
  • Tavis Rudd
    Hi Daniele, sorry I missed your first email to this list. I believe you re right. I ll commit that change to the cvs now and it will be included in 1.0rc2.
    Message 1 of 2 , Nov 2, 2005
      Hi Daniele,
      sorry I missed your first email to this list. I believe you're right. I'll
      commit that change to the cvs now and it will be included in 1.0rc2.
      Cheers,
      Tavis

      On Wednesday 02 November 2005 15:37, Daniele Varrazzo wrote:
      > Hello Mr. Rudd,
      >
      > i wrote for a bug report about a month ago and never got an answer.
      > Then, i messed up with my email accounts... Now i prefer to hear a word
      > from you.
      >
      > I notice the WebSafe filter doesn't convert None to blank string but
      > directly write them town as the string "None", as opposite as stated in
      > many docs. Did the expected behavior change?
      >
      > I can see the real behavior changed in the switch from r.1.18 and
      > r.1.19, as can be seen in
      > http://cvs.sourceforge.net/viewcvs.py/cheetahtemplate/Cheetah/src/Filters.p
      >y?r1=1.18&r2=1.19, where the None replacing was moved from the Filter class
      > to the
      > ReplaceNone class. But all the Filter subclasses call its 'filter()'
      > method to get the None removed.
      >
      > An easy fix would be changing the base class for WebSafe, MaxLen,
      > Pager... into ReplaceNone.
      >
      > Is my analysis right? Do you want me to provide a patch and/or a test
      > case for the issue?
      >
      > Regards,
      >
      > Daniele


      -------------------------------------------------------
      SF.Net email is sponsored by:
      Tame your development challenges with Apache's Geronimo App Server. Download
      it for free - -and be entered to win a 42" plasma tv or your very own
      Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
      _______________________________________________
      Cheetahtemplate-discuss mailing list
      Cheetahtemplate-discuss@...
      https://lists.sourceforge.net/lists/listinfo/cheetahtemplate-discuss
    • Tavis Rudd
      I ve just recut 1.0rc1 to include this change. ... SF.Net email is sponsored by: Tame your development challenges with Apache s Geronimo App Server. Download
      Message 2 of 2 , Nov 2, 2005
        I've just recut 1.0rc1 to include this change.

        On Wednesday 02 November 2005 16:01, Tavis Rudd wrote:
        > Hi Daniele,
        > sorry I missed your first email to this list. I believe you're right. I'll
        > commit that change to the cvs now and it will be included in 1.0rc2.
        > Cheers,
        > Tavis
        >
        > On Wednesday 02 November 2005 15:37, Daniele Varrazzo wrote:
        > > Hello Mr. Rudd,
        > >
        > > i wrote for a bug report about a month ago and never got an answer.
        > > Then, i messed up with my email accounts... Now i prefer to hear a word
        > > from you.
        > >
        > > I notice the WebSafe filter doesn't convert None to blank string but
        > > directly write them town as the string "None", as opposite as stated in
        > > many docs. Did the expected behavior change?
        > >
        > > I can see the real behavior changed in the switch from r.1.18 and
        > > r.1.19, as can be seen in
        > > http://cvs.sourceforge.net/viewcvs.py/cheetahtemplate/Cheetah/src/Filters
        > >.p y?r1=1.18&r2=1.19, where the None replacing was moved from the Filter
        > > class to the
        > > ReplaceNone class. But all the Filter subclasses call its 'filter()'
        > > method to get the None removed.
        > >
        > > An easy fix would be changing the base class for WebSafe, MaxLen,
        > > Pager... into ReplaceNone.
        > >
        > > Is my analysis right? Do you want me to provide a patch and/or a test
        > > case for the issue?
        > >
        > > Regards,
        > >
        > > Daniele
        >
        > -------------------------------------------------------
        > SF.Net email is sponsored by:
        > Tame your development challenges with Apache's Geronimo App Server.
        > Download it for free - -and be entered to win a 42" plasma tv or your very
        > own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
        > _______________________________________________
        > Cheetahtemplate-discuss mailing list
        > Cheetahtemplate-discuss@...
        > https://lists.sourceforge.net/lists/listinfo/cheetahtemplate-discuss


        -------------------------------------------------------
        SF.Net email is sponsored by:
        Tame your development challenges with Apache's Geronimo App Server. Download
        it for free - -and be entered to win a 42" plasma tv or your very own
        Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
        _______________________________________________
        Cheetahtemplate-discuss mailing list
        Cheetahtemplate-discuss@...
        https://lists.sourceforge.net/lists/listinfo/cheetahtemplate-discuss
      Your message has been successfully submitted and would be delivered to recipients shortly.