Loading ...
Sorry, an error occurred while loading the content.

RE: [bacnet-mstpwg] Confusing text in 135-2010, 9.5.6.5

Expand Messages
  • Hartman, John
    In 135-2010 SoleMasterRestartMaintenancePFM, set RetryCount and TokenCount to zero; set TokenCount to one seems clearly to be an error, since it gives two
    Message 1 of 2 , Sep 20, 2012
    • 0 Attachment

      In 135-2010 SoleMasterRestartMaintenancePFM,

                     "set RetryCount and TokenCount to zero; set TokenCount to one"

      seems clearly to be an error, since it gives two different values for TokenCount.

       

      The first TokenCount COULD be replaced EventCount, as in the erratum you quote and in the ResetMaintenancePFM transition just above this one.

       

      But EventCount is only TESTED by the PASS_TOKEN and NO_TOKEN states, so the only places where resetting it will affect the operation of the TSM is in transitions to those states.

       

      PASS_TOKEN is entered via five transitions, all of which call SendFrame and then reset EventCount to 0

       

      NO_TOKEN is entered only from IDLE, which resets EventCount to 0

       

      My personal opinion is that since EventCount is defined as "Used to count the number of received octets or errors", I think that it should be reset to zero IN the SendFrame procedure.  That would slightly reduce the verbosity of the state descriptions, and reduce worries about whether EventCount is reset everywhere it should be.

       

       

       

       

      -----Original Message-----
      From: bacnet-mstpwg@yahoogroups.com [mailto:bacnet-mstpwg@yahoogroups.com] On Behalf Of kerlyn2001
      Sent: Friday, September 07, 2012 12:54 PM
      To: bacnet-mstpwg@yahoogroups.com
      Subject: [bacnet-mstpwg] Confusing text in 135-2010, 9.5.6.5

       

      In 135-2010, the SoleMasterRestartMaintenancePFM transition from

      DONE_WITH_TOKEN (sub-clause 9.5.6.5) currently reads:

       

      "... set RetryCount and TokenCount to zero; set TokenCount to one;

       and enter ..."

       

      In Addendum 135-2004d-8 (approved by ANSI on June 30, 2006)

      http://www.ashrae.org/File%20Library/docLib/Public/20060905_1352004_addd.pdf

      EventCount was removed and this was changed to read:

       

      "... set RetryCount and TokenCount to zero; and enter ..."

       

      In Standard 135-2004 Errata (January 24, 2009)

      http://www.bacnet.org/Errata/135-2004-Errata-1-24-2009.pdf

      EventCount reappears and TokenCount goes to one:

       

      "... set RetryCount and EventCount to zero; set TokenCount to one;

      and enter ..."

       

      So my question is whether EventCount should be set to zero in this

      transition or not?  If so, then the line should read:

       

      "... set RetryCount to zero; set TokenCount to one; and enter ..."

       

      Thanks, -K-

       

       

       

      ------------------------------------

       

      Yahoo! Groups Links

       

      <*> To visit your group on the web, go to:

          http://groups.yahoo.com/group/bacnet-mstpwg/

       

      <*> Your email settings:

          Individual Email | Traditional

       

      <*> To change settings online go to:

          http://groups.yahoo.com/group/bacnet-mstpwg/join

          (Yahoo! ID required)

       

      <*> To change settings via email:

          bacnet-mstpwg-digest@yahoogroups.com

          bacnet-mstpwg-fullfeatured@yahoogroups.com

       

      <*> To unsubscribe from this group, send an email to:

          bacnet-mstpwg-unsubscribe@yahoogroups.com

       

      <*> Your use of Yahoo! Groups is subject to:

          http://docs.yahoo.com/info/terms/

       

       




      The information contained in this message is privileged and intended only for the recipients named. If the reader is not a representative of the intended recipient, any review, dissemination or copying of this message or the information it contains is prohibited. If you have received this message in error, please immediately notify the sender, and delete the original message and attachments.
    Your message has been successfully submitted and would be delivered to recipients shortly.