Loading ...
Sorry, an error occurred while loading the content.

Re: Some bug in Request::ParseParams()

Expand Messages
  • Josh Chamas
    ... Good point. I just did some testing, and chr(...) seems to be faster than pack( C ,...) so I ll use that instead, and we will have this in the next
    Message 1 of 3 , Mar 12, 2003
    • 0 Attachment
      Nikolay Melekhin wrote:
      > Hello!
      > I think that in Request.pm there is a small error
      >
      > 270c270
      > < $todecode =~ s/%([0-9a-fA-F]{2})/pack("C",hex($1))/ge;
      > ---
      >
      >> $todecode =~ s/%([0-9a-fA-F]{2})/pack("c",hex($1))/ge;
      >
      >

      Good point. I just did some testing, and chr(...) seems to be faster
      than pack("C",...) so I'll use that instead, and we will have this in the
      next release:

      $todecode =~ s/%([0-9a-fA-F]{2})/chr(hex($1))/ge;

      Regards,

      Josh

      ________________________________________________________________
      Josh Chamas, Founder phone:925-552-0128
      Chamas Enterprises Inc. http://www.chamas.com
      NodeWorks Link Checking http://www.nodeworks.com


      ---------------------------------------------------------------------
      To unsubscribe, e-mail: asp-unsubscribe@...
      For additional commands, e-mail: asp-help@...
    Your message has been successfully submitted and would be delivered to recipients shortly.