Loading ...
Sorry, an error occurred while loading the content.

2.5.0 snapshot, amflush.c bug report

Expand Messages
  • Jon LaBadie
    I m running 2.5.0, the Nov 2, 99 shapshot. These seem no longer available, at least no reference to it immediately comes to eye on Sourceforge. Have there
    Message 1 of 3 , Jul 3, 2000
    • 0 Attachment
      I'm running 2.5.0, the Nov 2, '99 shapshot.

      These seem no longer available, at least no reference
      to it immediately comes to eye on Sourceforge.

      Have there been any bug-reports for amflush in this
      release? I encountered one the first time I needed it
      due to stupidity of not switching tape cartridges over
      the weekend.

      I analyzed the problem and came up with a workaround,
      but I don't think that it is the proper solution.
      Perhaps someone more familiar with the code can work
      out a proper fix.


      Details:

      conf_logdir is a static external char *.

      It is set in amflush.c:main:140 with the line

      conf_logdir = getconf_str(CNF_LOGDIR);

      though there is no check for success it succeds on my runs
      and conf_logdir points at "/usr/local/etc/amanda/DS1".


      amflush.c:detach:310 is called from amflush.c:main:159.

      The detach function creates a child process to do the real work
      and exits the parent. Even in the parent, at line 320,
      conf_logdir has been reset somewhere to NULL. Not an empty
      string, the NULL address.

      The result of this results in line amflush.c:detach:325,

      errfile = vstralloc(conf_logdir, "/amflush", NULL);

      returns a null string to errfile and the open(2) call on the
      next line has a segmentation violation.


      My simple workaround was to reassign conf_logdir at the start
      of detach(), still in the parent, by duplicating line 140.

      It would be better to find out where it is being reset to NULL.

      jon
      --
      Jon H. LaBadie jon@...
      JG Computing jon@...
      4455 Province Line Road (609) 252-0159
      Princeton, NJ 08540-4322 (609) 683-7220 (fax)
    • John R. Jackson
      ... I don t think these were ever available anyplace other than through Alexandre s web page. ... This was reported and fixed last November (shortly after the
      Message 2 of 3 , Jul 3, 2000
      • 0 Attachment
        >I'm running 2.5.0, the Nov 2, '99 shapshot.
        >
        >These seem no longer available, at least no reference
        >to it immediately comes to eye on Sourceforge.

        I don't think these were ever available anyplace other than through
        Alexandre's web page.

        >I analyzed the problem and came up with a workaround,
        >but I don't think that it is the proper solution. ...

        This was reported and fixed last November (shortly after the snapshot
        you are using -- figures :-). I'd suggest you get the latest code via
        CVS from Sourceforge.

        If that's not an option, ask me again and I'll give you the patch. Or you
        can probably do it by hand. Just remove the amfree of conf_logdir that
        appears near line 150 (right after the amfree of conf_logfile).

        >jon

        John R. Jackson, Technical Software Specialist, jrj@...
      • Alexandre Oliva
        ... I have removed the links, since I haven t created snapshot for such a long time, and we encourage the use of the CVS tree instead. -- Alexandre Oliva
        Message 3 of 3 , Jul 3, 2000
        • 0 Attachment
          On Jul 3, 2000, "John R. Jackson" <jrj@...> wrote:

          >> I'm running 2.5.0, the Nov 2, '99 shapshot.
          >>
          >> These seem no longer available, at least no reference
          >> to it immediately comes to eye on Sourceforge.

          > I don't think these were ever available anyplace other than through
          > Alexandre's web page.

          I have removed the links, since I haven't created snapshot for such a
          long time, and we encourage the use of the CVS tree instead.

          --
          Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
          Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
          CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
          Free Software Evangelist *Please* write to mailing lists, not to me
        Your message has been successfully submitted and would be delivered to recipients shortly.